fix: fall back to direct CF lookup when UPS not found in list - #311
Merged
alex-gilin merged 1 commit intoJun 21, 2026
Merged
Conversation
When binding a grantor service to a UPS, the CF Cloud Controller list API has eventual consistency — a newly created (or recently updated) instance may not appear in GET /v3/service_instances immediately, even though it exists. The requstedInstance code path threw immediately on a list miss with no fallback, causing sporadic bind failures. Fix: if the instance is not found in the available-services list, retry via getServiceInstanceInfo() (a direct metadata lookup by name) before throwing. If found, inject the result into availableServices so the subsequent instance-resolution loop does not issue a redundant second fetch. Tests updated accordingly. Fixes: https://jira.tools.sap/browse/DEVXBUGS-12663
rimasirich
approved these changes
Jun 21, 2026
alex-gilin
deleted the
fix/DEVXBUGS-12663-ups-binding-eventual-consistency
branch
June 21, 2026 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When binding a grantor service to a UPS, the CF Cloud Controller list API has eventual consistency — a newly created (or recently updated) instance may not appear in GET /v3/service_instances immediately, even though it exists. The requstedInstance code path threw immediately on a list miss with no fallback, causing sporadic bind failures.
Fix: if the instance is not found in the available-services list, retry via getServiceInstanceInfo() (a direct metadata lookup by name) before throwing. If found, inject the result into availableServices so the subsequent instance-resolution loop does not issue a redundant second fetch. Tests updated accordingly.
Fixes: [DEVXBUGS-12663]