fix: DwC Auth Token not available #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
added
bug
MatKuhr
commented
Feb 29, 2024
| @@ -1 +0,0 @@ | |||
| com.sap.cloud.sdk.cloudplatform.security.secret.ScpCfSecretStoreFacade | |||
There was a problem hiding this comment.
driveby cleanup of dead code
MatKuhr
commented
Feb 29, 2024
| @@ -1 +0,0 @@ | |||
| com.sap.cloud.sdk.cloudplatform.security.DefaultAuthTokenFacade | |||
There was a problem hiding this comment.
removing this should be fine because the Accessor uses this facade regardless by default (without classloading)
There was a problem hiding this comment.
It doesn't if the DwcAuthTokenFacade is class loaded
newtork
reviewed
Mar 6, 2024
newtork
reviewed
Mar 6, 2024
...nectivity-dwc/src/main/java/com/sap/cloud/sdk/cloudplatform/security/DwcAuthTokenFacade.java
Show resolved
Hide resolved
MatKuhr
commented
Mar 6, 2024
There was a problem hiding this comment.
currently drafting an E2E test here based on this test code.
...dplatform/connectivity-dwc/src/main/java/com/sap/cloud/sdk/cloudplatform/DwcHeaderUtils.java
Show resolved
Hide resolved
...dplatform/connectivity-dwc/src/main/java/com/sap/cloud/sdk/cloudplatform/DwcHeaderUtils.java
Outdated
Show resolved
Hide resolved
...nectivity-dwc/src/main/java/com/sap/cloud/sdk/cloudplatform/security/DwcAuthTokenFacade.java
Show resolved
Hide resolved
Comment on lines
+23
to
+27
| @Test | ||
| void testFacadeIsPickedUpAutomatically() | ||
| { | ||
| assertThat(AuthTokenAccessor.getAuthTokenFacade()).isInstanceOf(DwcAuthTokenFacade.class); | ||
| } |
| private static AuthToken extractAuthTokenFromDwcHeaders() | ||
| { | ||
| try { | ||
| final String token = DwcHeaderUtils.getDwcTokenOrThrow(); |
There was a problem hiding this comment.
[question]
Can you remind me what we decided regarding "DwC header injection" attacks (i.e. someone somehow calls the app and injects their own dwc-* headers)?
I know we discussed this topic a while back but cannot quite recall what we decided.
There was a problem hiding this comment.
we figured not an issue for various reasons, including for example:
- the dwc dependencies don't come in automatically and it's decently unlikely that they can come transitively outside of DwC
- even if they are present, the multi tenancy would not work at all without the dwc headers, so any multi-tenant app should detect this during development
Co-authored-by: Johannes Schneider <[email protected]>
13 tasks
13 tasks
jingweiz2017
pushed a commit
to jingweiz2017/cloud-sdk-java
that referenced
this pull request
Aug 28, 2024
… enhancement on top of SAP#337 to include dwc-ias-jwt in header as auth token as well. dwc-ias-jwt is the key used for auth token when dwc is integrated with ias for authentication.
jingweiz2017
pushed a commit
to jingweiz2017/cloud-sdk-java
that referenced
this pull request
Aug 29, 2024
… enhancement on top of SAP#337 to include dwc-ias-jwt in header as auth token as well. dwc-ias-jwt is the key used for auth token when dwc is integrated with ias for authentication.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#424.
I think we just forgot to implement this earlier. This change makes our
AuthTokenAccessoractually return a token in the DwC case. Without this change, one always gets an exception (unless using CAP).Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated