feat: Allow access to failed batch request #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix-closeresource-pmd-warning
…nto fix-closeresource-pmd-warning
CharlesDuboisSAP
changed the title
newtork
reviewed
Mar 6, 2024
...src/main/java/com/sap/cloud/sdk/datamodel/odata/client/exception/ODataResponseException.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Mar 6, 2024
...ain/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataHealthyResponseValidator.java
Outdated
Show resolved
Hide resolved
CharlesDuboisSAP
added
please merge
CharlesDuboisSAP
changed the title
…tent-id # Conflicts: # datamodel/odata-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/MultipartParser.java
…el/odata/client/request/ODataRequestResultMultipartGeneric.java
…to 426-failedBatchRequestNumber # Conflicts: # datamodel/odata-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/exception/ODataResponseException.java # datamodel/odata-client/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataHealthyResponseValidator.java
# Conflicts: # release_notes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue raised in the backlog item #426. It introduces changes to allow users to access responses of failed "sub-requests" in a batch request. This is achieved by mapping the batch request content to the response via the
Content-ID.Changes
The changes in this PR are as follows:
The
requireHealthyResponsemethod in theODataHealthyResponseValidatorclass is modified. It now tries to extract theContent-IDfrom the HTTP response and uses it to create anODataResponseException.The field
requestofODataExceptionnow stores the specific failed OData batch changeset.testBatchWithErrorInChangeset()checks thatexception.getRequest()now always return the failed changeset.Instructions for Reviewers
Please review the changes in the context of the batch request handling. Pay special attention to the error handling and the new test case. Please also verify if the
Content-IDis correctly extracted from the HTTP response and if therequestfield is correctly set in theODataException.