chore: Use ServiceIdentifier Constants from the Service Binding Library
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed until 09/24. DO NOT DELETE THE BRANCH |
# Conflicts: # cloudplatform/connectivity-oauth/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/IdentityAuthenticationServiceBindingDestinationLoader.java # cloudplatform/connectivity-oauth/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/IdentityAuthenticationServiceBindingDestinationLoaderTest.java
CharlesDuboisSAP
added
please merge
CharlesDuboisSAP
previously approved these changes
Apr 18, 2024
added 2 commits
May 2, 2024 09:14
…P/cloud-sdk-java into chore/use-service-identifiers
|
Closed until we decide to increase our minimum SBL version. DO NOT DELETE THIS BRANCH |
CharlesDuboisSAP
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#428
This PR refactors our implementation to make use of the
ServiceIdentifierconstants provided by the SBL.This has not been done earlier to avoid potential runtime issues caused by version conflicts of the SBL.
This PR also reverts: Make Service Binding Library usage backwards-compatible