fix: Redundant NPE in DefaultHttpDestination#equals and #hashCode
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
reviewed
Mar 22, 2024
| if( ks == null ) { | ||
| return new Certificate[0]; | ||
| } | ||
|
|
||
| final ArrayList<Certificate> out = new ArrayList<>(); | ||
| try { |
There was a problem hiding this comment.
(minor) for which cases do we actually need the try here? Is there any legitimate failure case we need to handle?
There was a problem hiding this comment.
"Everything" on KeyStore is prone to exceptions being thrown, especially since we never know what kind of implementation is running internally. That's why we need a try.
Example (independent from implementation)
KeyStoreException("Uninitialized keystore")ifKeyStorewas notload-ed.
newtork
added
please merge
MatKuhr
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #341
Not critical, since NPE is being caught by default.
However it's easily possible to avoid throwing the exception.