refactor: add review comment changes

SAP · Feb 14, 2025 · bd6d512 · bd6d512
1 parent d9c2860
commit bd6d512
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/packages/adp-tooling/src/base/project-builder.ts b/packages/adp-tooling/src/base/project-builder.ts
@@ -1,13 +1,12 @@
 import { CommandRunner } from '@sap-ux/nodejs-utils';
 
 /**
- * Executes a build command in the specified project directory and cleans up `.js.map` files
- * in the provided target directory.
+ * Executes a build command in the specified project directory.
  *
  * This function uses the `CommandRunner` to run the build process via the command `npm run build`.
  *
  * @param {string} projectPath - The absolute path to the project directory where the build command will be executed.
- * @returns {Promise<void>} Resolves when the build process and cleanup are completed successfully.
+ * @returns {Promise<void>} Resolves when the build process has completed successfully.
  * @throws {Error} If the build process fails or if an error occurs during cleanup.
  */
 export async function runBuild(projectPath: string): Promise<void> {

diff --git a/packages/adp-tooling/test/unit/writer/__snapshots__/index.test.ts.snap b/packages/adp-tooling/test/unit/writer/__snapshots__/index.test.ts.snap
@@ -282,7 +282,7 @@ builder:
       afterTask: generateCachebusterInfo
       configuration:
         target:
-          destination: UYTCLNT902
+          destination: DUMMY_DESTINATION
         app:
           package: $TMP
 ",
@@ -317,14 +317,14 @@ server:
       configuration:
         adp:
           target:
-            destination: UYTCLNT902
+            destination: DUMMY_DESTINATION
           ignoreCertErrors: false
     - name: fiori-tools-proxy
       afterMiddleware: fiori-tools-preview
       configuration:
         ignoreCertError: false # If set to true, certificate errors will be ignored. E.g. self-signed certificates will be accepted
         backend:
-          - destination: UYTCLNT902
+          - destination: DUMMY_DESTINATION
             url: https://REQUIRED_FOR_VSCODE.example
             path: /sap
         ui5:
@@ -344,7 +344,7 @@ builder:
           - sap: testId
             i18n: testKey
         target:
-          destination: UYTCLNT902
+          destination: DUMMY_DESTINATION
           url: https://REQUIRED_FOR_VSCODE.example
 ",
     "state": "modified",
@@ -1585,7 +1585,7 @@ builder:
       afterTask: generateCachebusterInfo
       configuration:
         target:
-          destination: UYTCLNT902
+          destination: DUMMY_DESTINATION
         app:
           package: $TMP
 ",
@@ -1620,14 +1620,14 @@ server:
       configuration:
         adp:
           target:
-            destination: UYTCLNT902
+            destination: DUMMY_DESTINATION
           ignoreCertErrors: false
     - name: fiori-tools-proxy
       afterMiddleware: fiori-tools-preview
       configuration:
         ignoreCertError: false # If set to true, certificate errors will be ignored. E.g. self-signed certificates will be accepted
         backend:
-          - destination: UYTCLNT902
+          - destination: DUMMY_DESTINATION
             url: https://REQUIRED_FOR_VSCODE.example
             path: /sap
         ui5:
@@ -1647,7 +1647,7 @@ builder:
           - sap: testId
             i18n: testKey
         target:
-          destination: UYTCLNT902
+          destination: DUMMY_DESTINATION
           url: https://REQUIRED_FOR_VSCODE.example
 ",
     "state": "modified",

diff --git a/packages/adp-tooling/test/unit/writer/index.test.ts b/packages/adp-tooling/test/unit/writer/index.test.ts
@@ -198,7 +198,7 @@ describe('ADP writer', () => {
                     reference: 'the.original.app'
                 },
                 target: {
-                    destination: 'UYTCLNT902'
+                    destination: 'DUMMY_DESTINATION'
                 }
             };