WIP: Feat/2172/convert local preview files #2504
Draft
+2,069
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvert-local-preview-files # Conflicts: # packages/app-config-writer/src/index.ts
…P/open-ux-tools into feat/2172/convert-local-preview-files
…files' into feat/2172/convert-local-preview-files
heimwege
commented
Nov 13, 2024
| skipPreviewMiddlewareCreation = false | ||
| ): Promise<void> { | ||
| const ui5YamlConfig = await readUi5Yaml(basePath, ui5Yaml, fs); | ||
| let previewMiddleware = await getPreviewMiddleware(ui5YamlConfig); |
There was a problem hiding this comment.
Seems like ui5-config does not include comments when loading a specific middleware config 🤷🏻 So writing it after some changes will actually delete the comment even if that part has not been touched at all. @tobiasqueck Is this a bug in ui5-config?
Sample:
- name: fiori-tools-preview
afterMiddleware: compression
configuration:
libs: true
debug: true
adp:
target:
url: <some url>
client: '080'
authenticationType: reentranceTicket
# destination: <some name>
ignoreCertErrors: true
rta:
editors:
- path: /test/adaptation-editor.html
developerMode: truewill become
- name: fiori-tools-preview
afterMiddleware: compression
configuration:
libs: true
debug: true
flp:
path: just/a/path/flp.html
adp:
target:
url: <some url>
client: '080'
authenticationType: reentranceTicket
ignoreCertErrors: true
rta:
editors:
- path: /test/adaptation-editor.html
developerMode: true…P/open-ux-tools into feat/2172/convert-local-preview-files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2172
app-config-writer/convert + create
convertwith parameterpreviewthat converts an app to virtual preview filesapp-config-writer/variants-config
project-access
getAllUi5YamlFileNamesthat reads all yaml files in the given directory and (optionally) validates the schema to ensure it's a valid UI5 yaml configuration file. Currently multi-document sources (=yaml files containing---or...) are not supported and will be skippedbuildrun script to download the UI5 yaml schema todistto also support offline schema validationspreview-middleware