Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy-config-generator): adds new module @sap-ux/deploy-config-generator-shared #2563

Merged
merged 20 commits into from
Nov 25, 2024
Merged

feat(deploy-config-generator): adds new module @sap-ux/deploy-config-generator-shared #2563

merged 20 commits into from
Nov 25, 2024

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Nov 13, 2024 •
edited
Loading

#2526

Adds new module @sap-ux/deploy-config-generator-shared

  • Contains base class all deployment generators will extend
  • Central location for common error messages and constants used across the deployment generators

@cianmSAP cianmSAP requested a review from a team as a code owner November 13, 2024 16:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3e3107a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/deploy-config-generator-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP mentioned this pull request Nov 18, 2024
Closed
IainSAP
IainSAP approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

  • Base shared deploy gen code to support sub-gens to come
  • Tests added to cover

longieirl
longieirl approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP
Changes look good.

@cianmSAP cianmSAP requested a review from devinea November 25, 2024 10:03
devinea
devinea approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module set-up looks good.
changeset ✅

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cianmSAP cianmSAP merged commit 7c9e0cc into main Nov 25, 2024
15 checks passed
@cianmSAP cianmSAP deleted the feat/abap-deploy-gen/2526-deploy-gen-shared branch November 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longieirl longieirl longieirl approved these changes

@devinea devinea devinea approved these changes

@IainSAP IainSAP IainSAP approved these changes

Assignees

@cianmSAP cianmSAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cianmSAP @longieirl @devinea @IainSAP