Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-components): UITranslationInput. Screen readers read the resolved translation tooltip/title of UITranslationInput as part of the screen reader speech #2568

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

815are
Copy link
Contributor

@815are 815are commented Nov 14, 2024

accessibility team reported issue, that additional information is read by screen reader:
image

It is about part with Value: .... Translation: ....

This text is coming from title attribute - we resolve by purpose within UITranslation input to show it in tooltip.
As solution - move title attribute from input to wrapper element. In result tooltip appears as before, but screen reader ignores it.

image

from screen reader
image

enhance translation input
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 3045892

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/ui-components Patch
@sap-ux/ui-prompting Patch
@sap-ux-private/ui-prompting-examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@815are 815are changed the title fix(ui-components): title is read by screen reader and duplicated text containing value twite fix(ui-components): UITranslationInput. Screen readers read the resolved translation tooltip/title of UITranslationInput as part of the screen reader speech Nov 14, 2024
@815are 815are marked this pull request as ready for review November 14, 2024 16:56
@815are 815are requested a review from a team as a code owner November 14, 2024 16:56
Copy link

sonarcloud bot commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant