Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The adaptive card manifest should not be saved. #2902

Merged
merged 9 commits into from
Feb 24, 2025
5 changes: 5 additions & 0 deletions .changeset/khaki-cups-kiss.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sap-ux/cards-editor-middleware': patch
---

The adaptive card manifest should not be saved
1 change: 0 additions & 1 deletion packages/cards-editor-middleware/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ module.exports = async ({ resources }: MiddlewareParameters<any>): Promise<Reque
const multipleCards = utils.prepareCardTypesForSaving(manifests);

await promises.writeFile(join(fullPath, file), multipleCards.integration);
await promises.writeFile(join(fullPath, 'adaptive-' + file), multipleCards.adaptive);

const oManifest = JSON.parse(await manifest.getString());

Expand Down
2 changes: 1 addition & 1 deletion packages/cards-editor-middleware/test/unit/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ describe('sap-cards-generator', () => {
const server = await getTestServer('lrop-v4');
const response = await server.post(sapCardsGenerator.ApiRoutes.cardsStore).send(payload);
expect(response.status).toBe(201);
expect(mockFsPromisesWriteFile).toHaveBeenCalledTimes(3);
expect(mockFsPromisesWriteFile).toHaveBeenCalledTimes(2);
});
});

Expand Down