Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: default aggregation index #2933

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Fix: default aggregation index #2933

merged 8 commits into from
Feb 19, 2025

Conversation

Jimmy-Joseph19
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 commented Feb 18, 2025

Set default aggregation array index For Fev2/Fev4 apps to 1 for Add Custom Page and Add Custom Table Action

@Jimmy-Joseph19 Jimmy-Joseph19 requested a review from a team as a code owner February 18, 2025 09:13
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 17215ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nahmed22
nahmed22 previously approved these changes Feb 19, 2025
Copy link
Member

@nahmed22 nahmed22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Chageset found for packages.
Test coverage is good.
Tested, works as expected.
Approving.

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Test coverage is good
Didn't test locally

@vadson71 vadson71 requested a review from nahmed22 February 19, 2025 14:06
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code changes looks good
  • good test coverage
  • did not test locally

@nahmed22 nahmed22 merged commit 583c4cd into main Feb 19, 2025
16 checks passed
@nahmed22 nahmed22 deleted the fix/defaultIndexForCustomPage branch February 19, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants