Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create custom table action v2 app #2941

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Conversation

nahmed22
Copy link
Member

v2 table custom action "QA" not working when headerToolBar is undefined/null

@nahmed22 nahmed22 added the control-property-editor @sap-ux/control-property-editor label Feb 18, 2025
@nahmed22 nahmed22 requested a review from a team as a code owner February 18, 2025 15:39
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 608eca7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vadson71
vadson71 previously approved these changes Feb 19, 2025
Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Covered in tests
Didn't test locally

@nahmed22 nahmed22 requested a review from vadson71 February 19, 2025 13:17
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Chageset found for packages.
Test coverage good.
Tested locally and works as expected.
Approving.

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good
Excellent test coverage
Comments addressed
Didn't test locally

@nahmed22 nahmed22 merged commit fd3bfb0 into main Feb 19, 2025
16 checks passed
@nahmed22 nahmed22 deleted the fix/33183/customTableAction branch February 19, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control-property-editor @sap-ux/control-property-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants