-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create custom table action v2 app #2941
Conversation
🦋 Changeset detectedLatest commit: 608eca7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Covered in tests
Didn't test locally
packages/preview-middleware-client/test/unit/adp/quick-actions/fe-v2.test.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/test/unit/adp/quick-actions/fe-v2.test.ts
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Chageset found for packages.
Test coverage good.
Tested locally and works as expected.
Approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good
Excellent test coverage
Comments addressed
Didn't test locally
v2 table custom action "QA" not working when headerToolBar is undefined/null