Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Path Compatibility for Windows in FF Test Template Generation #2957

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Feb 26, 2025

Bug fix related to PR

  • The previous logic for filtering files based on the ui5 template version was not platform-compatible, causing the webapp/integration and webapp/test folders to not be generated on Windows.
  • This fix replaces hardcoded path separators with platform-specific functions, ensuring consistent behaviour across all platforms.

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 14c4013

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/ui5-test-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review February 26, 2025 09:43
devinea
devinea previously approved these changes Feb 26, 2025
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem appropriate fix for windows issue.
changeset ✅

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed
Changes are clear
Not tested
Appropriate changeset

@kjose90 kjose90 merged commit f4867e5 into main Feb 26, 2025
16 checks passed
@kjose90 kjose90 deleted the fix/freestyle-test-templates-win branch February 26, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants