Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor conditional logic for test generation in FF writer #2985

Merged
merged 7 commits into from
Mar 5, 2025
Merged

Refactor conditional logic for test generation in FF writer #2985

merged 7 commits into from
Mar 5, 2025

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Mar 3, 2025

Refactor conditional logic for test generation in FF writer
related to open source PR

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 94c2cee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fiori-freestyle-writer Minor
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review March 4, 2025 07:18
@kjose90 kjose90 requested a review from a team as a code owner March 4, 2025 07:18
IainSAP
IainSAP previously approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Makes writer more resilient to misconfiguration
  • Tetst added

longieirl
longieirl previously approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Changeset is good.
Tests updated.

@kjose90 kjose90 requested a review from a team as a code owner March 5, 2025 07:56
lfindlaysap
lfindlaysap requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting tweak suggestion, @kjose90.

@kjose90 kjose90 dismissed stale reviews from longieirl and IainSAP via bdaa885 March 5, 2025 10:43
devinea
devinea approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear and covered by tests
changeset ✅

longieirl
longieirl approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Changeset is good.
Tests are good.

@lfindlaysap lfindlaysap self-requested a review March 5, 2025 11:42
lfindlaysap
lfindlaysap approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good. Will look at formatting as part of a separate PR.

@kjose90
Copy link
Member Author

kjose90 commented Mar 5, 2025

Thanks for reviews.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kjose90 kjose90 merged commit ebc6dfa into main Mar 5, 2025
16 checks passed
@kjose90 kjose90 deleted the add-log-ff-test-templates branch March 5, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longieirl longieirl longieirl approved these changes

@devinea devinea devinea approved these changes

@lfindlaysap lfindlaysap lfindlaysap approved these changes

@IainSAP IainSAP IainSAP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjose90 @longieirl @devinea @IainSAP @lfindlaysap