fix: (CXSPA-9651) Continuum E2Es - Payment Methods #20158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

StanislavSukhanov merged 5 commits into develop from feature/CXSPA-9651-Continuum-E2Es---Payment-Methods

Apr 22, 2025

Contributor

StanislavSukhanov commented Apr 8, 2025

introduced a new test suite for checking accessibility concerns for Payment Methods Page
closes: https://jira.tools.sap/browse/CXSPA-9651

StanislavSukhanov self-assigned this

github-actions bot marked this pull request as draft

April 8, 2025 11:35

StanislavSukhanov marked this pull request as ready for review

April 8, 2025 11:35

Contributor

github-actions bot commented Apr 8, 2025

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

StanislavSukhanov force-pushed the feature/CXSPA-9651-Continuum-E2Es---Payment-Methods branch from 357d56a to 7757e47 Compare

April 9, 2025 12:43

StanislavSukhanov requested a review from a team as a code owner

April 9, 2025 12:43

github-actions bot marked this pull request as draft

April 9, 2025 12:44

StanislavSukhanov marked this pull request as ready for review

April 9, 2025 12:47

cypress bot commented Apr 9, 2025 •

edited

Loading

spartacus Run #47798

Run Properties: Passed #47798 • 2389b0a1fc ℹ️: Merge 461f267cf08ee0e0330445d583b7b099e8e011dd into dd3940eb91b8ef86c6dd1637c239...

Project	`spartacus`
Branch Review	`feature/CXSPA-9651-Continuum-E2Es---Payment-Methods`
Run status	`Passed #47798`
Run duration	`04m 44s`
Commit	`2389b0a1fc ℹ️: Merge 461f267cf08ee0e0330445d583b7b099e8e011dd into dd3940eb91b8ef86c6dd1637c239...`
Committer	`Stanislav Sukhanov`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`107`
View all changes introduced in this branch ↗︎

StanislavSukhanov changed the title ~~chore: (CXSPA-9649) Continuum E2Es - Payment Methods~~ fix: (CXSPA-9649) Continuum E2Es - Payment Methods

Pio-Bar requested changes

View reviewed changes

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.e2e.cy.ts Outdated

Comment on lines 17 to 19

+                  it('Page loaded', () => {
+                    cy.get('main').a11yRunContinuumTest();
+                  });

Contributor

Pio-Bar Apr 11, 2025

Wait for content to load, otherwise the site is mostly empty.

Contributor Author

StanislavSukhanov Apr 11, 2025

weird, i've re-checked it I'll check again. Thank you

Contributor

Pio-Bar Apr 14, 2025

I think it's a race between the page loading and AccessEngine being setup. It might be safest to always wait for content to avoid flaky results.

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.e2e.cy.ts Outdated

Contributor

Pio-Bar Apr 11, 2025

Let's follow the naming convention.

Contributor Author

StanislavSukhanov Apr 11, 2025

sure.

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.e2e.cy.ts Outdated

+              import { viewportContext } from '../../helpers/viewport-context';
+              describe('Payment Methods Page accessibility', { testIsolation: false }, () => {
+                viewportContext(['desktop', 'mobile'], () => {

Contributor

Pio-Bar Apr 11, 2025

If there are no different elements between the mobile and desktop versions, no need to run this twice.

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.e2e.cy.ts Outdated

+                  it('Delete payment method', () => {
+                    cy.get('cx-card').first().find('button').click();
+                    cy.get('main').a11yRunContinuumTest();

Contributor

Pio-Bar Apr 11, 2025

We can just scan the modified element instead of the whole page again. Let's set the scope to just the unique card.

Contributor Author

StanislavSukhanov Apr 11, 2025

roger that

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.e2e.cy.ts Outdated

+                  it('set as default', () => {
+                    cy.get('cx-card').eq(1).find('button').first().click();
+                    cy.get('.alert-success').a11yRunContinuumTest();
+                    cy.get('main').a11yRunContinuumTest();

Contributor

Pio-Bar Apr 11, 2025

Does this test do anything different compared to the first main scan?

Contributor Author

StanislavSukhanov Apr 11, 2025

nope. It's just checking if there are no accessibility concerns after the change was made

Contributor Author

StanislavSukhanov Apr 11, 2025

remove the last thing since it's been checked previously

StanislavSukhanov changed the title ~~fix: (CXSPA-9649) Continuum E2Es - Payment Methods~~ fix: (CXSPA-9651) Continuum E2Es - Payment Methods

StanislavSukhanov force-pushed the feature/CXSPA-9651-Continuum-E2Es---Payment-Methods branch from 7757e47 to 8b0f407 Compare

April 11, 2025 15:01

github-actions bot marked this pull request as draft

April 11, 2025 15:01

StanislavSukhanov requested a review from Pio-Bar

April 14, 2025 09:20

Pio-Bar requested changes

View reviewed changes

Contributor

Pio-Bar left a comment

Looks good! just a minor nitpick. 😉

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.a11y-e2e.cy.ts Outdated

+              import { viewportContext } from '../../helpers/viewport-context';
+              describe('Payment Methods Page accessibility', { testIsolation: false }, () => {
+                viewportContext(['desktop'], () => {

Contributor

Pio-Bar Apr 14, 2025

Since the desktop is the default, I think this might be redundant?

StanislavSukhanov force-pushed the feature/CXSPA-9651-Continuum-E2Es---Payment-Methods branch from 8b0f407 to 5dea72a Compare

April 14, 2025 11:49

StanislavSukhanov requested a review from Pio-Bar

April 14, 2025 12:04

Pio-Bar previously approved these changes

View reviewed changes

Zeyber requested changes

View reviewed changes

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.a11y-e2e.cy.ts Outdated

+              describe('Payment Methods Page accessibility', { testIsolation: false }, () => {
+                before(() => {
+                  cy.a11yContinuumSetup();
+                  cy.login('[email protected]', 'pw4all');

Contributor

Zeyber Apr 15, 2025

We should import the credentials from local sample data files. There should be examples of this in other tests.

Contributor Author

StanislavSukhanov Apr 17, 2025

fixed

projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/payment-methods.a11y-e2e.cy.ts Outdated

+                before(() => {
+                  cy.a11yContinuumSetup();
+                  cy.login('[email protected]', 'pw4all');
+                  cy.visit('/my-account/payment-details');

Contributor

Zeyber Apr 15, 2025

When I logged in with this user, there were no existing payment methods available. Did you create this user or find it from somewhere? Any new user would need sample data created so I'd check out using the standard user from sampledata to see if it has some payment details already there.

Contributor Author

StanislavSukhanov Apr 17, 2025

fixed

StanislavSukhanov added 4 commits

April 17, 2025 13:01


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods

3c45341

* introduced a new test suite for checking accessibility concerns for order history
* addressed accessibility concerns found by a test.

* closes: https://jira.tools.sap/browse/CXSPA-9651


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods

a1dbd41

* introduced a new test suite for checking accessibility concerns for order history
* addressed accessibility concerns found by a test.

* closes: https://jira.tools.sap/browse/CXSPA-9651


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods

9827ef9

* introduced a new test suite for checking accessibility concerns for order history
* addressed accessibility concerns found by a test.

* closes: https://jira.tools.sap/browse/CXSPA-9651


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods

efe7883

* introduced a new test suite for checking accessibility concerns for order history
* addressed accessibility concerns found by a test.

* closes: https://jira.tools.sap/browse/CXSPA-9651

StanislavSukhanov dismissed Pio-Bar’s stale review via

efe7883

April 17, 2025 11:02

StanislavSukhanov force-pushed the feature/CXSPA-9651-Continuum-E2Es---Payment-Methods branch from 5dea72a to efe7883 Compare

April 17, 2025 11:02

StanislavSukhanov marked this pull request as ready for review

April 17, 2025 11:04

Zeyber approved these changes

View reviewed changes


          Merge branch 'develop' into feature/CXSPA-9651-Continuum-E2Es---Payme…

461f267

…nt-Methods

github-actions bot marked this pull request as draft

April 22, 2025 07:51

StanislavSukhanov marked this pull request as ready for review

April 22, 2025 08:01

StanislavSukhanov merged commit 3f2eab5 into develop

30 checks passed

StanislavSukhanov deleted the feature/CXSPA-9651-Continuum-E2Es---Payment-Methods branch

April 22, 2025 08:24

rmch91 pushed a commit that referenced this pull request


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods (#20158)

82190df

rmch91 pushed a commit that referenced this pull request


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods (#20158)

197721b

rmch91 pushed a commit that referenced this pull request


          fix: (CXSPA-9651) Continuum E2Es - Payment Methods (#20158)

ca80abe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet