fix: failing test

SAP · Apr 3, 2024 · 6d0d00a · 6d0d00a
1 parent a27de6e
commit 6d0d00a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/packages/xml-views-definition/src/controller/index.ts b/packages/xml-views-definition/src/controller/index.ts
@@ -71,10 +71,7 @@ export async function getControllerLocation(
     if (el.value?.type !== "string-value") {
       return [];
     }
-    const text = el.value.text
-      .split("/")
-      .join(".")
-      .replace(/('|")$/g, "");
+    const text = el.value.text.split("/").join(".").replace(/'|"/g, "");
 
     const fileUri = await buildFileUri(id, text, manifestPath, exts);
     if (!fileUri) {

diff --git a/packages/xml-views-definition/tsconfig.json b/packages/xml-views-definition/tsconfig.json
@@ -3,8 +3,7 @@
   "compilerOptions": {
     "rootDir": ".",
     "outDir": "lib",
-    "baseUrl": ".",
-    "noImplicitReturns": false
+    "baseUrl": "."
   },
   "include": ["src/**/*", "test/**/*", "api.d.ts"]
 }
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -11,7 +11,7 @@
     "forceConsistentCasingInFileNames": true,
     "strict": true,
     "noImplicitAny": false,
-    "noImplicitReturns": true,
+    "noImplicitReturns": false,
     "esModuleInterop": true,
     "skipLibCheck": true,
     "types": ["node", "jest", "jest-extended"]

diff --git a/tsconfig.json b/tsconfig.json
@@ -30,6 +30,9 @@
     {
       "path": "./packages/xml-views-validation"
     },
+    {
+      "path": "./packages/xml-views-definition"
+    },
     {
       "path": "./test-packages/test-utils"
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,9 @@ @@
         {
           "path": "./packages/xml-views-validation"
         },
+        {
+          "path": "./packages/xml-views-definition"
+        },
         {
           "path": "./test-packages/test-utils"
         },
@@ Expand Down @@