Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add goto controller's definition from xml view files #701

Merged
merged 15 commits into from
Apr 3, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Mar 25, 2024

Issue: #702

This PR creates a new module "@ui5-language-assistant/xml-views-definition" and implement go to controller's definition (.js or .ts) from xml view files. It support following format.

  • object notation
core:require="{helper: 'sap/ui/demo/walkthrough/controller/Helper'}"
  • dot notation
controllerName="sap.ui.demo.walkthrough.controller.App"

The only considered xml attributes are

  • "controllerName"
  • "template:require"
  • "core:require"

File resolution logic is as follows:

  1. it tries to load <path>.controller.js
  2. it tries to load <path>.js
  3. it tries to load <path>.controller.ts
  4. it tries to load <path>.ts

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 0262f3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-definition Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-tooltip Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Apr 3, 2024

@marufrasully marufrasully merged commit ceab281 into master Apr 3, 2024
9 checks passed
@marufrasully marufrasully deleted the feat/add-goto-definition branch April 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants