Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min ui5 version as array #714

Merged
merged 4 commits into from
Jul 24, 2024
Merged

fix: min ui5 version as array #714

merged 4 commits into from
Jul 24, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Jul 18, 2024

issue: #715

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: 1b82e8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
vscode-ui5-language-assistant Patch
@ui5-language-assistant/test-utils Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-definition Patch
@ui5-language-assistant/xml-views-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marufrasully marufrasully marked this pull request as ready for review July 22, 2024 12:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Approving. Did not test locally

@kranthie-sap
Copy link

@marufrasully: As requested, I am merging this PR using admin privileges since there seems to be a sonarcloud configuration issue that will be addressed in another PR.

@kranthie-sap kranthie-sap merged commit fa811f5 into master Jul 24, 2024
8 of 9 checks passed
@kranthie-sap kranthie-sap deleted the fix/min-ui5 branch July 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants