-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate unique ID across view files in an application #719
Conversation
🦋 Changeset detectedLatest commit: fec1fe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b2f3399
to
7d30ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a lot of toHaveBeenCalledTimes
checks in tests, which makes the tests too focused on the implementation details and not actually testing the output. Majority of the times it adds very little value to the test and just makes it more difficult to refactor the tested function, because you will need to update the tests.
packages/xml-views-validation/src/validators/document/non-unique-id.ts
Outdated
Show resolved
Hide resolved
packages/xml-views-validation/src/validators/document/non-unique-id.ts
Outdated
Show resolved
Hide resolved
It depends what we want to check. Sometimes we are only interested in return signatures of a method e.g |
|
Issue: #646
dependent on this PR: #721