Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate unique ID across view files in an application #719

Merged
merged 21 commits into from
Aug 21, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Aug 7, 2024

Issue: #646
dependent on this PR: #721

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: fec1fe8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-definition Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/xml-views-tooltip Patch
@ui5-language-assistant/user-facing-text Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/language-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of toHaveBeenCalledTimes checks in tests, which makes the tests too focused on the implementation details and not actually testing the output. Majority of the times it adds very little value to the test and just makes it more difficult to refactor the tested function, because you will need to update the tests.

@marufrasully
Copy link
Contributor Author

toHaveBeenCalledTimes

It depends what we want to check. Sometimes we are only interested in return signatures of a method e.g getContext In this case mocking make sense as underlaying methods have their respective unit tests.

Copy link

@marufrasully marufrasully merged commit d6ceeaa into master Aug 21, 2024
9 checks passed
@marufrasully marufrasully deleted the feat/generate-id branch August 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants