Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp for adaption project - first iteration #733

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

marufrasully
Copy link
Contributor

This PR solves

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: dd963ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/test-framework Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/xml-views-definition Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/xml-views-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem reasonable.
Test coverage should be better, but as far as I know it will be improved in the next iteration
Didn't test locally

@kranthie-sap
Copy link

Merging using admin privileges as requested.

@kranthie-sap kranthie-sap merged commit 6fe3662 into master Oct 9, 2024
8 of 9 checks passed
@kranthie-sap kranthie-sap deleted the fix/lsp-adp branch October 9, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants