Skip to content

Conversation

zypA13510
Copy link
Contributor

  • added an example of injecting DOM to global scope
  • added test on global context cleanup (ref: Global pollution and memory leak #7)
  • fixed a possible oversight in API documentation, type of context should be an object, not a string.

As with the previous PR, tests need to be updated if #5 is merged.

@zypA13510
Copy link
Contributor Author

Tests updated to reflect changes in #5

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zypA13510
❌ nathanss
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants