Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-notification-lit-group-item]: group header height should be shorter #9911

Closed
1 task done
LidiyaGeorgieva opened this issue Sep 20, 2024 · 1 comment · Fixed by #9953
Closed
1 task done

[ui5-notification-lit-group-item]: group header height should be shorter #9911

LidiyaGeorgieva opened this issue Sep 20, 2024 · 1 comment · Fixed by #9953
Assignees
@kskondov
Labels
bug This issue is a bug in the code Low Prio Medium Prio TOPIC RD

Comments

@LidiyaGeorgieva
Copy link
Contributor

Bug Description

group header should be shorter
{C8787CDE-0F95-4ECA-AECA-2499530E2693}

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. open https://sap.github.io/ui5-webcomponents/nightly/components/fiori/NotificationList/#notification-list-with-group-items
  2. collapse all groups
  3. they don't look OK

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

main

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@LidiyaGeorgieva LidiyaGeorgieva added the bug This issue is a bug in the code label Sep 20, 2024
@LidiyaGeorgieva LidiyaGeorgieva changed the title [ui5-notification-lit-group-item]: group header should be shorter [ui5-notification-lit-group-item]: group header height should be shorter Sep 20, 2024
@IlianaB
Copy link
Member

IlianaB commented Sep 20, 2024

Hello @SAP/ui5-webcomponents-topic-rd , please have a look at this issue. According to the VD spec, the height of the group header of notification list group should be 2.75rem.

Regards,
Iliana

@kskondov kskondov self-assigned this Sep 25, 2024
kskondov added a commit that referenced this issue Sep 27, 2024
@kskondov
fix(ui5-notification-list-group): group header hight is shorter when …
da1dddc 
…collapsed

There was too much space between collapsed group headers

Fixes: #9911
@kskondov kskondov mentioned this issue Sep 27, 2024
Merged
kskondov added a commit that referenced this issue Oct 14, 2024
@kskondov
fix(ui5-notification-list-group): group header hight is shorter when …
4c8a76e 
…collapsed (#9953)


Removes unnecessary space between collapsed group headers

Fixes: #9911
kgogov pushed a commit that referenced this issue Oct 30, 2024
@kskondov @kgogov
fix(ui5-notification-list-group): group header hight is shorter when …
10e8d2a 
…collapsed (#9953)


Removes unnecessary space between collapsed group headers

Fixes: #9911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kskondov kskondov

Labels
bug This issue is a bug in the code Low Prio Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-notification-list-group): group header hight is shorter when collapsed SAP/ui5-webcomponents
3 participants
@kskondov @LidiyaGeorgieva @IlianaB