Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-notification-list-group): group header hight is shorter when collapsed #9953

Merged
merged 5 commits into from
Oct 14, 2024
Merged

fix(ui5-notification-list-group): group header hight is shorter when collapsed #9953

merged 5 commits into from
Oct 14, 2024

Conversation

kskondov
Copy link
Contributor

There was too much space between collapsed group headers

Fixes: #9911

@kskondov
fix(ui5-notification-list-group): group header hight is shorter when …
da1dddc 
…collapsed

There was too much space between collapsed group headers

Fixes: #9911
@kskondov kskondov requested review from LidiyaGeorgieva and a team September 27, 2024 08:06
LidiyaGeorgieva
LidiyaGeorgieva reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the group is expanded/collapsed the group header changes its position. This is a bug

packages/fiori/src/themes/NotificationListGroupItem.css Outdated Show resolved Hide resolved
LidiyaGeorgieva
LidiyaGeorgieva reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All else looks OK

packages/fiori/src/NotificationListGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/NotificationListGroupItem.hbs Outdated Show resolved Hide resolved
@kskondov kskondov merged commit 4c8a76e into main Oct 14, 2024
10 checks passed
@kskondov kskondov deleted the ui5_notification_list_group_collapsed branch October 14, 2024 06:40
kgogov pushed a commit that referenced this pull request Oct 30, 2024
@kskondov @kgogov
fix(ui5-notification-list-group): group header hight is shorter when …
10e8d2a 
…collapsed (#9953)


Removes unnecessary space between collapsed group headers

Fixes: #9911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-notification-lit-group-item]: group header height should be shorter
2 participants
@kskondov @LidiyaGeorgieva