Skip to content

fix: remove inline styles and fix footer text constrast in light mode#37347

Closed
Zoya220 wants to merge 1 commit into
SAPTARSHI-coder:mainfrom
Zoya220:fix/footer-lightmode-contrast
Closed

fix: remove inline styles and fix footer text constrast in light mode#37347
Zoya220 wants to merge 1 commit into
SAPTARSHI-coder:mainfrom
Zoya220:fix/footer-lightmode-contrast

Conversation

@Zoya220

@Zoya220 Zoya220 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Pull Request Description

This PR fixes Issue #36299 where the website footer text became completely invisible/unreadable when switching the theme to Light Mode.


Type of Change

  • ✨ New animation / hover effect
  • 🧩 New component
  • 📝 Documentation improvement
  • 🐛 Bug fix in an existing submission
  • Other (describe below)

Submission Checklist

⚠️ Core Bug Fix Exemption: This PR addresses a repository-wide core styling issue (#36299) assigned by maintainers, rather than a standalone user submission component.


Feature Description

What does this add?

It restores accessible text color contrast to the global documentation footer when using the light mode theme layout.

How does a developer use it?

The fix operates automatically across the documentation site (docs/demo.html) when a user triggers the light mode color preference theme.

Why does it fit EaseMotion CSS?

It ensures the documentation layout remains accessible, beautiful, and functional across all user theme choices.


Demo

  • Demo verified locally (footer text is now high-contrast charcoal #4b5563 instead of low-contrast white).

Browser Testing

  • Chrome
  • Firefox
  • Edge
  • Safari

Notes for Maintainer

The original landing page had a hardcoded inline style (color:rgba(255,255,255,0.3)) directly on the footer paragraph inside docs/demo.html which completely overrode stylesheet color rules. I stripped that out and added an explicit, accessible #4b5563 text color fallback inside the light mode media query block in components/footer.css.

@Zoya220 Zoya220 requested a review from SAPTARSHI-coder as a code owner July 6, 2026 21:06
@github-actions github-actions Bot added animation Animation effects, hover interactions, motion ideas, transitions documentation Improvements or additions to documentation ECSoC26 good first issue Good for newcomers GSSoC-26 Official GSSoC 2026 issue gssoc:approved Approved for GSSoC contributions help wanted Extra attention needed level:advanced Complex issue requiring deep understanding type:bug type:docs labels Jul 6, 2026
@SAPTARSHI-coder SAPTARSHI-coder added the invalid This doesn't seem right label Jul 6, 2026
@SAPTARSHI-coder

Copy link
Copy Markdown
Owner

❌ PR Closed — Files Outside submissions/ Folder

@Zoya220, this PR has been automatically closed because it modifies files outside the allowed submissions/ directory:

  • components/footer.css
  • docs/demo.html

What to do

Contributions must only add files inside the submissions/ folder. Please:

  1. Create a new branch
  2. Add only your submission files under submissions/examples/your-feature-name/
  3. Open a new PR

See the contribution guide for details.

— EaseMotion CSS Guard

@SAPTARSHI-coder

Copy link
Copy Markdown
Owner

🔒 Pull Request Closed: This PR has been automatically closed because it does not contain any file changes under the submissions/ directory. Contributors must place their submissions under the submissions/ directory (e.g., submissions/examples/your-feature-name/ or submissions/docs/your-feature-name/). Thank you!

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 CSS Bundle Size Benchmark

This PR changes the size of easemotion.min.css.

Metric Base Branch This PR Difference
Raw 173.98 KB 174.00 KB 📈 +0.02 KB
Gzip 28.59 KB 28.59 KB 📈 +0.01 KB
Brotli 22.64 KB 22.66 KB 📈 +0.02 KB

@SAPTARSHI-coder

Copy link
Copy Markdown
Owner

❌ Submission Validation Failed

Thank you for your contribution! However, some required files are missing or incorrect.

📋 Required Structure

submissions/your-category/your-feature-name/ (e.g., submissions/examples/ or submissions/docs/)
├── demo.html     ← Interactive demo with DOCTYPE, html, head, body tags
├── style.css     ← Your original CSS (not copy-pasted from a template)
└── README.md     ← Brief description of your feature

🔍 Issues Found:

🔠 Strict Code Integrity Protection

  • ❌ Repository rule violation: You are not allowed to change existing code. Modified existing files: components/footer.css, docs/demo.html.
  • ❌ Repository rule violation: You are not allowed to delete any code.

🔠 Core Framework Protection

  • ❌ PR modifies core framework/configuration files: components/footer.css, docs/demo.html. Contributors may only modify files inside the submissions/ directory.

🔠 Submission Folder Protection

  • ❌ This PR does not contain any additions inside the submissions/ directory. Contributors must place their submissions under the submissions/ directory (e.g. submissions/examples/your-feature-name/ or submissions/docs/your-feature-name/).

📝 How to Fix:

  1. Ensure all 3 files exist with real, original content
  2. demo.html must have <!DOCTYPE html>, <html>, <head>, <body> tags
  3. style.css must contain your own CSS (not copy-pasted boilerplate)
  4. Push fixes to this branch — the validator will re-run automatically

📖 See CONTRIBUTING.md for full guidelines.

@SAPTARSHI-coder

Copy link
Copy Markdown
Owner

🔒 Pull Request Closed

This PR was automatically closed because it failed the submission validation check.

Please fix the issues listed above, then open a new pull request. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

animation Animation effects, hover interactions, motion ideas, transitions documentation Improvements or additions to documentation ECSoC26 good first issue Good for newcomers gssoc:approved Approved for GSSoC contributions gssoc:invalid GSSoC-26 Official GSSoC 2026 issue help wanted Extra attention needed invalid This doesn't seem right invalid-submission level:advanced Complex issue requiring deep understanding needs-files type:bug type:docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants