Feature/secure print #1836
Open
Feature/secure print #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanugarte
reviewed
Jul 28, 2025
Comment on lines
208
to
216
| if(!user){ | ||
| throw new Error('user not found'); // checks user | ||
| } | ||
| if(!Number.isInteger(pagesToPrint) || pagesToPrint <= 0){ | ||
| throw new Error('invalid number'); | ||
| } | ||
| if (user.pagesPrinted < pagesToPrint) { | ||
| throw new Error('no pages remaining'); | ||
| } |
Collaborator
There was a problem hiding this comment.
instead of throwing an error just do logger.error here and return early, we dont have to return anything
api/main_endpoints/routes/Printer.js
Outdated
Comment on lines
121
to
126
| const stream = await fs.promises.readFile(assembledPdfFromChunks); // buffer | ||
| const pdfDoc = await PDFDocument.load(stream); // load PDF | ||
| const numpages = pdfDoc.getPages().length; // get number of pages | ||
| const copiesInt = parseInt(copies || 1, 10); | ||
| const totalPages = numpages * copiesInt; | ||
| await subtractUserPages(user.id, totalPages); // updates users printcount |
Collaborator
There was a problem hiding this comment.
move this code in the existing try block in axios.post(PRINTER_URL ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.