Fix PS5.1 compatibility and add path-length warning in build.ps1#2515
Open
dcwhite wants to merge 1 commit into
Open
Fix PS5.1 compatibility and add path-length warning in build.ps1#2515dcwhite wants to merge 1 commit into
dcwhite wants to merge 1 commit into
Conversation
Replace the PowerShell 7-only ?? null-coalescing operator with a PS 5.1-compatible if/else block so the script works on the Windows-default PS version. Add a runtime warning when the resolved build directory path exceeds 50 characters, and expand the -BuildDir parameter documentation to explain the Windows MAX_PATH (260-char) limit that causes cryptic MSVC C1083 errors in deeply nested Superbuild trees. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
??null-coalescing operator (line 739) with a PS 5.1-compatibleif/elseblock — fixes a parse error on Windows' default PowerShell version reported in #2512-BuildDirparameter documentation with anIMPORTANTnote on the MAX_PATH limit, recommended short paths (C:\SR,D:\build), and update the example accordinglyTest plan
build.ps1on Windows PowerShell 5.1 (the default) — should no longer error on??C:\Users\...) and confirm the path-length warning fires-BuildDir "C:\SR"and confirm no warning and clean configure/buildGet-Help .\build.ps1 -Fullshows the updated-BuildDirdocumentationCloses the issue reported in #2512
🤖 Generated with Claude Code