fix: memoryleak

[Wtoto]

Summary by CodeRabbit

• Bug Fixes
  • Improved memory management to prevent potential app freezes or crashes when displaying animated images.

[coderabbitai]

Walkthrough

The change updates the KVO observation closure in the AnimatedImageViewWrapper class to weakly capture self, safely unwrapping it before invoking invalidateIntrinsicContentSize(). This adjustment prevents retain cycles and avoids executing the closure if the wrapper instance has been deallocated.

Changes

File(s)	Change Summary
SDWebImageSwiftUI/Classes/ImageViewWrapper.swift	Modified KVO closure to weakly capture and safely unwrap self before calling a method.

Poem

In the warren of code, a cycle was found,
A closure held tight, looping around.
Now with a whisper—weak and light—
The wrapper hops free, out of sight.
No more tangles, no more plight,
Just clean, safe code—oh what delight! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 451c6df and 765aea0.

📒 Files selected for processing (1)

• SDWebImageSwiftUI/Classes/ImageViewWrapper.swift (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Unit Test (iOS)
• GitHub Check: Unit Test (macOS)
• GitHub Check: Unit Test (tvOS)
• GitHub Check: Run Demo
• GitHub Check: Build Library

🔇 Additional comments (3)

SDWebImageSwiftUI/Classes/ImageViewWrapper.swift (3)

76-81: Well done fixing the memory leak issue!

Great improvement to prevent a retain cycle. Using [weak self] with a guard check properly breaks the strong reference cycle between the AnimatedImageViewWrapper and its observation closure. This ensures proper deallocation of the wrapper when it's no longer needed.

---

87-92: Good consistency applying the same fix here.

The same memory leak fix is correctly applied to the second initializer, ensuring consistent behavior regardless of how the view is initialized.

---

25-27: Verification: Deinit implementation is correct.

The deinit method correctly invalidates the observation, which completes the proper cleanup when the wrapper is deallocated. This works well with your newly added weak self pattern.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.