Skip to content

Fix the issue when provide a UIAnimatedImage and encode it into a static WebP failed #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

dreampiggy
Copy link
Contributor

Add a backup check of image.images.

See the demo code to trigger this issue:

UIImage *animatedImage = [UIImage sd_imageWithGIFData:gifData];
NSData *staticWebP = [SDImageWebPCoder.sharedCoder encodedDataWithImage:animatedImage format:SDImageFormatWebP options:@{SDImageCoderEncodeFirstFrameOnly : @(YES)}]
NSParamAsset(staticWebP);

…tatic WebP failed. Add a backup check of image.images
@dreampiggy dreampiggy requested a review from a team January 28, 2019 07:54
@dreampiggy dreampiggy merged commit ead68a0 into master Jan 28, 2019
@dreampiggy dreampiggy deleted the bugfix_encoding_first_frame branch January 28, 2019 09:22
@dreampiggy dreampiggy added this to the 0.1.2 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant