Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fiesta #103

Merged
merged 10 commits into from
Jun 12, 2023
Merged

Fix Fiesta #103

merged 10 commits into from
Jun 12, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented May 21, 2023 •
edited
Loading

  • Keep track of imported namespaces (prevents errors for duplicate file/object loading)
  • Allow inherited member IDs to be prefixed with the fqon of the object the memer is inherited from
  • Fix a bug where nested objects before EOF crashed the parser
  • Check if the value of an optional container is None before reading values

@heinezen heinezen added improvement improves existing functionality c++ involves C++ code labels May 21, 2023
@heinezen heinezen changed the title Check if namespace is already loaded before importing Fix Fiesta May 26, 2023
TheJJ
TheJJ requested changes Jun 12, 2023
View reviewed changes
nyan/database.cpp Show resolved Hide resolved
nyan/database.cpp Outdated Show resolved Hide resolved
nyan/database.cpp Show resolved Hide resolved
nyan/meta_info.h Outdated Show resolved Hide resolved
nyan/object_info.h Outdated Show resolved Hide resolved
test/test.nyan
@@ -87,6 +87,11 @@ SetPatch<SetTest>():
member |= o{3,4,4}
orderedmember += o{4}

DictTest():
dictmember : dict(int, text) = {2: "two", 4: "four"}
dictmember2 : optional(dict(text, int)) = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could create a syntax sugar (kotlin does this): dict? is the same as optional(dict)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could make it more unreadable but why not? :)

@TheJJ TheJJ merged commit 97ab90a into SFTtech:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
c++ involves C++ code improvement improves existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ