Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve element wrapper #1723

Merged
merged 9 commits into from
Dec 25, 2024
Merged

Conversation

jere8184
Copy link
Contributor

@jere8184 jere8184 commented Dec 3, 2024

No description provided.

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code kevin-rebuild-pl0x instruct kevin to rebuild this pull request area: util Utilitis and data structures labels Dec 5, 2024
@SFTbot SFTbot removed kevin-rebuild-pl0x instruct kevin to rebuild this pull request labels Dec 5, 2024
libopenage/curve/element_wrapper.h Show resolved Hide resolved
libopenage/curve/element_wrapper.h Outdated Show resolved Hide resolved
libopenage/curve/element_wrapper.h Outdated Show resolved Hide resolved
libopenage/curve/element_wrapper.h Outdated Show resolved Hide resolved
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Dec 5, 2024
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Dec 5, 2024
@jere8184 jere8184 force-pushed the curve_element_wrapper branch 3 times, most recently from e890cf1 to 615441e Compare December 12, 2024 15:02
@jere8184 jere8184 force-pushed the curve_element_wrapper branch from 615441e to b306c76 Compare December 12, 2024 15:17
@jere8184 jere8184 requested a review from heinezen December 15, 2024 22:18
@heinezen
Copy link
Member

@jere8184 Btw if you have resolved a comment from my review, you can press the Resolve conversation button. Then I'll see if I should do the final review ;)

Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good now! I'm going to make a few adjustments to the comment formatting myself before merging.

@heinezen heinezen merged commit beb8945 into SFTtech:master Dec 25, 2024
13 checks passed
@heinezen
Copy link
Member

Very nice, thanks again.

@jere8184 jere8184 deleted the curve_element_wrapper branch December 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: util Utilitis and data structures improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants