Skip to content

Sisc1 52 be 주식 베팅 게임 구현 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kosw6 merged 9 commits into from
Nov 13, 2025
Merged

Sisc1 52 be 주식 베팅 게임 구현 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ccb944
[BE] SISC1-52 [FIX] 베팅 게임 버그 수정
otter2023 Nov 1, 2025
08c400d
[BE] SISC1-52 [DOCS] Swagger에 API 주석 추가
otter2023 Nov 11, 2025
8e01a8f
[BE] SISC1-52 [DOCS] Swagger에 Request 주석 추가
otter2023 Nov 11, 2025
cd8d834
Merge branch 'main' into SISC1-52-BE-주식-베팅-게임-구현
otter2023 Nov 11, 2025
4feba2c
[BE] SISC1-52 [FIX] 500 에러 수정
otter2023 Nov 12, 2025
757fe9c
[BE] SISC1-52 [DOCS] Swagger에 BetRound 주석 추가
otter2023 Nov 12, 2025
2c4eca0
[BE] SISC1-52 [FEAT] 테스트를 위한 스케쥴러의 api화
otter2023 Nov 12, 2025
63d3f91
plz
otter2023 Nov 12, 2025
4afd66b
Merge branch 'main' into SISC1-52-BE-주식-베팅-게임-구현
otter2023 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/src/main/java/org/sejongisc/backend/betting/controller/BettingController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ public class BettingController {
@ApiResponse(responseCode = "404", description = "활성 라운드가 존재하지 않음")
}
)

@GetMapping("/bet-rounds/{scope}")
public ResponseEntity<BetRound> getTodayBetRound(
@Parameter(description = "라운드 범위 (Scope): DAILY 또는 WEEKLY", example = "DAILY")
Expand Down
2 changes: 1 addition & 1 deletion backend/src/main/java/org/sejongisc/backend/betting/repository/BetRoundRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.util.UUID;

public interface BetRoundRepository extends JpaRepository<BetRound, UUID> {
Optional<BetRound> findByStatusTrueAndScope(Scope type);
Optional<BetRound> findTopByStatusTrueAndScopeOrderByOpenAtDesc(Scope type);

List<BetRound> findAllByOrderBySettleAtDesc();

Expand Down
27 changes: 18 additions & 9 deletions backend/src/main/java/org/sejongisc/backend/betting/service/BettingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class BettingService {
* 현재 활성화된 베팅 라운드 조회
*/
public Optional<BetRound> getActiveRound(Scope type) {
return betRoundRepository.findByStatusTrueAndScope(type);
return betRoundRepository.findTopByStatusTrueAndScopeOrderByOpenAtDesc(type);
}

/**
Expand All @@ -51,22 +51,31 @@ public List<BetRound> getAllBetRounds() {
* PriceData 기반 무작위 종목 선택 (기존 Stock 대체)
*/
public PriceResponse getPriceData() {
List<PriceData> priceList = priceDataRepository.findAll();
if (priceList.isEmpty()) {
List<PriceData> allData = priceDataRepository.findAll();
if (allData.isEmpty()) {
throw new CustomException(ErrorCode.STOCK_NOT_FOUND);
}

PriceData price = priceList.get(random.nextInt(priceList.size()));
List<String> tickers = allData.stream()
.map(PriceData::getTicker)
.distinct()
.toList();

String randomTicker = tickers.get(random.nextInt(tickers.size()));

PriceData latest = priceDataRepository.findTopByTickerOrderByDateDesc(randomTicker)
.orElseThrow(() -> new CustomException(ErrorCode.STOCK_NOT_FOUND));
Comment on lines +54 to +67
Copy link

@coderabbitai coderabbitai bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

성능 문제: 전체 데이터 로드를 피하세요.

현재 구현은 findAll()로 모든 PriceData를 메모리에 로드한 후 distinct ticker를 추출합니다. PriceData 테이블에 수천~수만 개의 레코드가 있는 경우 심각한 성능 저하가 발생할 수 있습니다.

다음과 같이 개선하는 것을 권장합니다:

방법 1: Repository에 distinct ticker 조회 메서드 추가 (권장)

PriceDataRepository에 메서드 추가:

@Query("SELECT DISTINCT p.ticker FROM PriceData p")
List<String> findDistinctTickers();

그 후 서비스 코드 수정:

-    List<PriceData> allData = priceDataRepository.findAll();
-    if (allData.isEmpty()) {
+    List<String> tickers = priceDataRepository.findDistinctTickers();
+    if (tickers.isEmpty()) {
         throw new CustomException(ErrorCode.STOCK_NOT_FOUND);
     }

-    List<String> tickers = allData.stream()
-            .map(PriceData::getTicker)
-            .distinct()
-            .toList();
-
     String randomTicker = tickers.get(random.nextInt(tickers.size()));

방법 2: Native Query 사용

@Query(value = "SELECT DISTINCT ticker FROM price_data", nativeQuery = true)
List<String> findDistinctTickers();
🤖 Prompt for AI Agents 
In
backend/src/main/java/org/sejongisc/backend/betting/service/BettingService.java
around lines 54 to 67, avoid loading all PriceData via findAll() — add a
repository method to fetch distinct tickers (either JPQL or native query) and
call that instead, then pick a random ticker from the returned list and query
for the latest PriceData for that ticker; update the service to use the new
repository method (handle empty result with the same CustomException) so only
ticker values are loaded into memory rather than all PriceData rows.


return PriceResponse.builder()
.name(price.getTicker())
.symbol(price.getTicker())
.name(latest.getTicker())
.symbol(latest.getTicker())
.market(MarketType.US)
.previousClosePrice(price.getClosePrice())
.settleClosePrice(price.getAdjustedClose())
.previousClosePrice(latest.getClosePrice())
.settleClosePrice(latest.getAdjustedClose())
.build();
}


/**
* 무료 베팅 가능 여부 (20% 확률)
*/
Expand Down Expand Up @@ -199,7 +208,7 @@ public void settleUserBets() {

for (BetRound round : activeRounds) {
// PriceData를 이용해 시세 조회
Optional<PriceData> priceOpt = priceDataRepository.findFirstByTickerOrderByDateDesc(round.getSymbol());
Optional<PriceData> priceOpt = priceDataRepository.findTopByTickerOrderByDateDesc(round.getSymbol());
if (priceOpt.isEmpty()) continue;

PriceData price = priceOpt.get();
Expand Down
2 changes: 1 addition & 1 deletion backend/src/main/java/org/sejongisc/backend/stock/repository/PriceDataRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
public interface PriceDataRepository extends JpaRepository<PriceData, PriceDataId> {
List<PriceData> findByTickerAndDateBetweenOrderByDateAsc(String ticker, LocalDate startDate, LocalDate endDate);
List<PriceData> findByTicker(String ticker);
Optional<PriceData> findFirstByTickerOrderByDateDesc(String ticker);
Optional<PriceData> findTopByTickerOrderByDateDesc(String ticker);
}