Skip to content

feat: 베팅 이력 리턴 값 추가#130

Merged
Kosw6 merged 1 commit intomainfrom
SISC1-BE-베팅게임-수정
Nov 22, 2025

Hidden character warning

The head ref may contain hidden characters: "SISC1-BE-\ubca0\ud305\uac8c\uc784-\uc218\uc815"
Merged

feat: 베팅 이력 리턴 값 추가#130
Kosw6 merged 1 commit intomainfrom
SISC1-BE-베팅게임-수정

Conversation

@cksdid202
Copy link
Contributor

@cksdid202 cksdid202 commented Nov 22, 2025

Summary by CodeRabbit

릴리스 노트

  • 새로운 기능
    • 베팅 응답에 추가 정보 제공: 이전 종가, 결제 종가, 상승 베팅 수, 하락 베팅 수가 이제 포함됩니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Walkthrough

UserBetResponse DTO에 네 개의 새로운 필드(previousClosePrice, settleClosePrice, upBetCount, downBetCount)가 추가되었습니다. 이 필드들은 BetRound 객체에서 값을 가져와 초기화되며, from() 메서드의 매핑 로직에서 처리됩니다.

Changes

Cohort / File(s) Summary
DTO 필드 확장
backend/src/main/java/org/sejongisc/backend/betting/dto/UserBetResponse.java
BetRound 관련 필드 4개 추가: previousClosePrice, settleClosePrice, upBetCount, downBetCount. from() 메서드에서 BetRound 객체로부터 해당 필드값들을 매핑하고, BigDecimal 및 BetRound 임포트 추가

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8분

  • 주의 사항:
    • BetRound에서 새로운 필드들(previousClosePrice, settleClosePrice, upBetCount, downBetCount)이 실제로 존재하는지 검증 필요
    • null 처리 로직 확인 (BetRound가 null인 경우 처리 여부)
    • BigDecimal 초기화 시 정밀도 및 반올림 처리 확인

Possibly related PRs

Suggested reviewers

  • discipline24

Poem

🐰 새로운 필드가 쏙 들어와
BetRound에서 데이터를 따와
DTO는 더욱 풍성해지고
응답값도 정보가 가득 담겼네요! 🎯✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 풀 리퀘스트의 주요 변경 사항인 베팅 이력 응답에 새로운 필드 추가를 명확하게 반영하고 있습니다.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch SISC1-BE-베팅게임-수정

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aefd543 and f1cfb9b.

📒 Files selected for processing (1)
  • backend/src/main/java/org/sejongisc/backend/betting/dto/UserBetResponse.java (3 hunks)
🔇 Additional comments (2)
backend/src/main/java/org/sejongisc/backend/betting/dto/UserBetResponse.java (2)

6-6: LGTM!

필요한 import 문이 정확하게 추가되었습니다.

Also applies to: 10-10


27-32: LGTM!

새로운 필드 선언이 적절합니다. 타입 선택(BigDecimal for prices, int for counts)과 주석이 명확합니다.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosw6 Kosw6 merged commit ab1004c into main Nov 22, 2025
1 check passed
@Kosw6 Kosw6 deleted the SISC1-BE-베팅게임-수정 branch November 22, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants