Skip to content

feat(pools): Web-pools-pools-table-empty-and-loading-states#276

Merged
IbrahimIjai merged 9 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-pools-pools-table-empty-and-loading-states
Jun 25, 2026
Merged

feat(pools): Web-pools-pools-table-empty-and-loading-states#276
IbrahimIjai merged 9 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-pools-pools-table-empty-and-loading-states

Conversation

@CAESARIAN-ATHENS

Copy link
Copy Markdown
Contributor

Here's a summary of what was done:

  1. Testing Setup:
    • Added happy-dom , @testing-library/react , and @testing-library/dom to the apps/web package.json dependencies.
    • Updated a failing dependency version ( @creit.tech/stellar-wallets-kit ) so bun install would succeed.
    • Created apps/web/setup-tests.ts to register happy-dom globally.
    • Added "test": "bun test --preload ./setup-tests.ts" to apps/web/package.json .
  2. Component Implementation ( apps/web/src/features/pools/components/gm-pools-table.tsx ):
    • Created the component that receives isLoading and pools props.
    • Implemented an animated loading state.
    • Implemented an empty state ("No pools found.") when pools is empty.
    • Designed a simple HTML table styled with standard Tailwind CSS to render the fixture rows (including Pool , TVL , and APR columns).
  3. Tests ( apps/web/src/features/pools/components/gm-pools-table.test.tsx ):
    • Wrote three tests that verify the loading state, empty state, and the rendering of fixture data.
    • Used accessible handles like screen.getByRole and screen.getByText rather than test IDs, as requested in the acceptance criteria.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Chidubemkingsley is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai IbrahimIjai merged commit f5c6028 into SO4-Markets:main Jun 25, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web pools: pools table empty and loading states

2 participants