Skip to content

Web trade trade panel default render#280

Merged
IbrahimIjai merged 11 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-trade-trade-panel-default-render
Jun 25, 2026
Merged

Web trade trade panel default render#280
IbrahimIjai merged 11 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-trade-trade-panel-default-render

Conversation

@CAESARIAN-ATHENS

Copy link
Copy Markdown
Contributor

TradePanel Test Suite Summary

Overview

Successfully implemented comprehensive test suite for the TradePanel component.

File: apps/web/src/features/trade/components/trade-panel/TradePanel.test.tsx

Status: ✅ All 8 tests passing


Test Coverage

Test Verification
Side selector tabs Renders Long, Short, Swap tabs via getByRole("tab")
Order mode buttons Renders Market, Limit, Trigger buttons
Collateral input Displays "Collateral" label and placeholder="0.00" input
Leverage slider Shows "Leverage" label and current value badge (e.g., 10×)
Submit button label Button text includes trade type + token symbol (e.g., "Long TWBTC")
Disabled when disconnected Button is disabled when walletStore.status === "disconnected"
Enabled with wallet + balance Button becomes enabled when connected, has balance, and fromAmount > 0
Market label for positions Shows "Market" label (not "Receive") for non-swap trades

Key Implementation Challenges Solved

Challenge Solution
Contract initialization error Mocked @/lib/contracts to prevent SyntheticsReaderClient constructor from crashing due to zero-address strkey decode failure
React Query dependencies Added QueryClientProvider wrapper via test helper to satisfy @tanstack/react-query requirements
ConfirmationDialog crash Added missing sidecarOrders property to mock trade controller to prevent sidecarOrders.length runtime error

Overall Test Results

✅ 79 tests passing
❌ 0 tests failing
📊 Suite-wide: All passing

--- closes #225

Test suite ensures robust UI behavior and edge case handling for the trade panel component.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Chidubemkingsley is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai IbrahimIjai merged commit 7e3f975 into SO4-Markets:main Jun 25, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web trade: trade panel default render

2 participants