Web trade trade panel default render#280
Merged
IbrahimIjai merged 11 commits intoJun 25, 2026
Merged
Conversation
…nd fix test imports
…e wallet store test API, fix minor type issues
…KeyboardShortcut test
…, useKeyboardShortcut ref pattern + cleanup, setup-tests env vars + URL + jest-dom
|
@Chidubemkingsley is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
… fix import order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TradePanel Test Suite Summary
Overview
Successfully implemented comprehensive test suite for the TradePanel component.
File:
apps/web/src/features/trade/components/trade-panel/TradePanel.test.tsxStatus: ✅ All 8 tests passing
Test Coverage
getByRole("tab")walletStore.status === "disconnected"fromAmount > 0Key Implementation Challenges Solved
@/lib/contractsto preventSyntheticsReaderClientconstructor from crashing due to zero-address strkey decode failureQueryClientProviderwrapper via test helper to satisfy@tanstack/react-queryrequirementssidecarOrdersproperty to mock trade controller to preventsidecarOrders.lengthruntime errorOverall Test Results
--- closes #225
Test suite ensures robust UI behavior and edge case handling for the trade panel component.