Skip to content

Web pools composition bar rendering#282

Merged
IbrahimIjai merged 4 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-pools-composition-bar-rendering
Jun 26, 2026
Merged

Web pools composition bar rendering#282
IbrahimIjai merged 4 commits into
SO4-Markets:mainfrom
CAESARIAN-ATHENS:Web-pools-composition-bar-rendering

Conversation

@CAESARIAN-ATHENS

Copy link
Copy Markdown
Contributor

Web-pools-composition-bar-rendering

Commit: 1560f4b


Test Results

Check Result
bun test ✅ 110 passing, 0 failing (11 files, +8 new tests)
eslint ✅ 0 errors on new file

New Test Coverage

Added 8 tests for the pools composition bar rendering:

Test Description
Normal split Verifies standard proportional bar segments
50/50 split Tests equal weight distribution
Zero long/short Edge case with no position in one direction
Clamping < 0 Ensures negative values are clamped to 0
Clamping > 100 Ensures values exceeding 100% are clamped
Bar widths Validates correct width calculations for each segment
Fractional % Handles decimal percentage values

Summary

Commit: 1560f4b
Status: ✅ All checks passing
Impact: +8 new tests, overall suite now at 110 passing tests across 11 files
Quality: No ESLint errors on new code

--- closes #222

Branch: Web-pools-composition-bar-rendering

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@Chidubemkingsley is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai IbrahimIjai merged commit 6dd4817 into SO4-Markets:main Jun 26, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web pools: composition bar rendering

2 participants