feat(landing): finish content, assets, and a11y/perf pass (GF3-003) - #617
Merged
Conversation
- Refactor hero section to remove volume link and adjust background animation. - Simplify launch section to represent SO4 as a single chain with a Stellar mark. - Update liquidity section to reflect accurate pool information and user engagement message. - Disable newsletter form with a clear message about upcoming functionality. - Enhance pool card with parallax lines and a coin icon for better visual representation. - Revise program cards to accurately reflect SO4 offerings and remove non-existent programs. - Adjust roadmap section to use stage labels instead of quarters, reflecting current project status. - Update social section with accurate links and placeholder values for follower counts. - Replace social slider content with product highlights instead of fabricated testimonials. - Modify sponsors section to accurately represent SO4's infrastructure partners. - Implement utility functions for formatting numbers and add tests for validation. - Improve accessibility in accordion component by using inert attribute for closed panels.
|
@0xMegie is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Great job |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #511
Finishes GF3-002's structural skeleton: every placeholder gets real copy or an
explicit, named gap; every missing GMX asset gets a hand-coded SVG/CSS
equivalent; accessibility and performance are measured against Lighthouse, not
assumed.
Copy — and what it replaced
Every claim on the page is now checked against the actual codebase (README.md,
referrals/data/tiers.ts,earn/data/pools.ts,useMarketsInfo.ts) rather thanadapted from GMX's own copy. That audit surfaced several claims GF3-002 had
shipped that don't hold up:
tiers.ts(5% flat discount, 5–15% affiliate commission); the invented developer card is droppedcontracts.ts's optional-router comments@handlesRotation words, FAQ, and pool names now match what the app actually ships (BTC/ETH/XLM markets, GM/GLV pool structure).
Assets
Hand-coded inline SVG/CSS throughout — hero glow repositioned to match
docs/gf_3/screenshots/hero-desktop.png, program-card glow, pool-card parallaxlines + coin mark, BTC/ETH/XLM asset marks, Stellar mark. No raster files, no
new dependencies.
Accessibility
Measured with Lighthouse against the actual production build (
vite preview,not dev mode):
Fixes behind those numbers:
packages/ui/src/components/accordion.tsx:aria-hiddenon a closed panel didn't stop a keyboard user from tabbing intoa link inside it. Fixed with
inert, covered by a new regression test.<main>landmark on the route.h1→h3, noh2— the feature grid had nosection heading in the DOM). Added a visually-hidden
h2.gmx-slate-500(adark-surface token per
001_theme_update.md) on light bands, andtext-white/70on the blue feature card.What's still open
Five
TODO(GF3-003)markers remain — each is a named external dependency, notleftover placeholder copy:
-stays the honest value.silently doing nothing on submit.
Found, not fixed (separate issue)
apps/web/vite.config.tsexternalizes@twind/corein the client build, butstellar-wallets-kit's wallet-selector UI imports it transitively — thisthrows a real browser console error (
Failed to resolve module specifier "@twind/core") on every route, not just/, and is part of why best-practicesisn't 100. Left alone since it's a wallet-connector build config bug, not a
landing content/asset issue — flagging for its own ticket.
Testing
Full gate passing:
bun lint,bun typecheck,bun run check:tokens,bun run test. Visual-regression baselines regenerated for/(4 files) plusthe 768px/1440px specs from GF3-002. New tests: an accordion regression test
for the
inertfix, plusformatters.test.ts(9 cases, previously untested).Side-by-side GMX-vs-SO4 screenshots per the acceptance criteria: [attach
manually against
docs/gf_3/screenshots/*.png— I don't have a way to capturegmx.io from here].
Reviewer note
Not all copy is final — several sections (roadmap dates, sponsor list,
newsletter endpoint) depend on facts only the maintainer has. Flagged inline
with
TODO(GF3-003)rather than guessed.