Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #ifNotNil:ifNil: to Nil and Object #123

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

smarr
Copy link
Member

@smarr smarr commented Feb 13, 2025

This PR adds the missing selector for nil checks, with the first branch being the non-nil case. This is mostly for symmetry and convenience, since we already had the #ifNil:ifNotNil: case.

This change is relied on in the AreWeFastYet benchmarks with smarr/are-we-fast-yet#99.

Core-Lib Updates

Status SOM PR
SOM (java) SOM-st/som-java#38
SOM++ SOM-st/SOMpp#59 & SOM-st/SOMpp#60
TruffleSOM SOM-st/TruffleSOM#227 & SOM-st/TruffleSOM#228
PySOM SOM-st/PySOM#64 & SOM-st/PySOM#65
JsSOM SOM-st/JsSOM#19
SOM-RS https://github.com/Hirevo/som-rs/pull/

@smarr smarr added enhancement Improves the implementation with something noteworthy language design This issue requires design decisions labels Feb 13, 2025
@smarr smarr merged commit e808008 into SOM-st:master Feb 13, 2025
6 checks passed
@smarr smarr deleted the if-not-nil branch February 13, 2025 18:19
smarr added a commit to SOM-st/SOMpp that referenced this pull request Feb 20, 2025
Adopts the changes of SOM-st/SOM#123 and
SOM-st/SOM#124.

This does not add any changes in SOM++ itself though.
They are separate in #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the implementation with something noteworthy language design This issue requires design decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant