Make code compatible with latest pytest-mh changes #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And therefore rename to CreateFromArgs.
And therefore renamed to init().
This functionality has been now included in pytest-mh.
implementation This functionality has been now included in pytest-mh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rewriting pytest-mh documentation I realized that some methods
are marked with underscore to make them private, however, these methods
are actually expected to be overwritten. Therefore they should be public.
Additionally, I also make our backup code generic and pushed it into pytest-mh. This is not a breaking change, but it starts using this generic code instead of our own implementation.