Skip to content

Conversation

madhuriupadhye
Copy link
Contributor

No description provided.

Signed-off-by: Madhuri Upadhye <[email protected]>
Comment on lines +60 to +61
# Check if BEAKER_RECIPE_ID environment variable is set
if [ -n "${BEAKER_RECIPE_ID}" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In IDM-CI, we have two providers one is openstack and other is beaker,
with openstack we get ipv6 adds but those are not configure, we can not ping them from one host to another host, but with beaker all is set for ipv6 adds so currently only IPV6 testing can be done with the system/hosts we get from beaker, so I explicitly add it to check from which provider we are getting the systems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to understand - we have ipv6 global addresses in openstack, they just do not work?

IMO the condition should be the other way around then. This way we get ipv6 in beaker and only in beaker. So if I locally set IPv6 virtual network, it will not work, because I do not have this variable set.

Can you think of something that shows we are in openstack and decide by this? Maybe our own variable added trough our openstack yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, is below Pseudocode looks okay, I did not try (getting issue to get beaker systems) but rough idea to implement like this?

FUNCTION DETERMINE_IPV6_FEATURE_STATUS:
    INITIALIZE ipv6_feature_enabled = FALSE

    IF system HAS global IPv6 addresses:
        PRINT "Global IPv6 addresses found."
        IF system CAN ping a known IPv6 target (e.g., Google's DNS or check and ping local IPV6 gateway):
            PRINT "IPv6 connectivity confirmed."
            SET ipv6_feature_enabled = TRUE
        ELSE:
            PRINT "WARNING: IPv6 addresses found, but connectivity failed."
    ELSE:
        PRINT "No global IPv6 addresses found."

    UPDATE application's features dictionary:
        SET "ipv6" feature to ipv6_feature_enabled

END FUNCTION

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be much better and more universal. There are several ways, for example:

ping -6 -c 1 google.com
wget --inet6-only -qO- https://redhat.com
..

Downside is that it requires internet connection. Perhaps we could try to ping gateway, not sure as pings can be disabled.

@madhuriupadhye
Copy link
Contributor Author

Hello @jakub-vavra-cz, I tried the way you suggested for dual network in metadata but it wont work, can I add this way or we can configure ipv6 with IDM-CI hosts?

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it will work only with machine from beaker and it might be better to figure out openstack solution as well..

@madhuriupadhye
Copy link
Contributor Author

Hello @pbrezina, can you please check it again? Can I keep it this way?

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants