ipa: restart SSSD and clean up before each test

[pbrezina]

If SSSD is already running, it may have opened file that no-longer exist
which resulted in unexpected errors, like KCM providing different
tickets.

Resolves: #203

[gemini-code-assist]

Summary of Changes

Hello @pbrezina, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the SSSD test framework where SSSD's state could become corrupted between test runs, leading to unexpected errors. By introducing a mandatory SSSD restart and cleanup before each test in the IPA role, the changes ensure a consistent and clean environment. Additionally, the set_service_user utility method has been extended to support IPA hosts and made more robust against missing feature flags.

Highlights

• SSSD State Management: Implemented a pre-test cleanup and restart of the SSSD service within the IPA role's setup phase. This ensures SSSD starts with fresh database files, preventing issues caused by stale or non-existent files from previous test runs.
• set_service_user Method Enhancement: Modified the set_service_user method to support IPAHost instances in addition to ClientHost instances, expanding its applicability within the test framework.
• Robust Feature Flag Check: Updated the non-privileged feature check to use .get("non-privileged", False), providing a default value and preventing potential KeyError exceptions for improved stability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to restart SSSD and clear its caches before each test run within the IPA role's setup. This is a good measure to ensure test isolation and prevent state leakage from previous runs. The changes also include a necessary adjustment in sssd.py to support IPAHost and make feature checking more robust. My only suggestion is to update the docstring of the modified setup method to reflect its new responsibilities.

[alexey-tikhonov]

If SSSD is already running, it may have opened file that no-longer exist
which resulted in unexpected errors, like KCM providing different
tickets.

Could you please describe in a greater details? So far it sounds like a bug in SSSD.

[pbrezina]

No, it is issue of the framework. The test needs to run at least twice, it will succeed the first time.

1. Test runs - success
2. This executes teardown which restores /var/lib/sss to original contents, removing secrets db and restoring original
3. sssd-kcm did not stopped so it has still opened the secrets.db that was removed
4. Another test is executed, kinit is run but since sssd-kcm still runs it writes it to the removed database
5. sssd is restarted, together with sssd-kcm
6. sssd-kcm opens new secrets db, which is the one from the backup

[sumit-bose]

Hi,

thanks for the fix, I will update my test once it is pushed to master, ACK.

bye,
Sumit