Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1150 - Fix crash when clicking on Staff without User record #1204

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vladislav-kir
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

#1150

  1. What was changed?
  • UserService | CreateUser - Automatically create a Staff record for new Staff users

  • UpsertStaffMemberProfileCommandHandler - Automatically create a User record for new Staff records

  • Added AchievementHelper | GenerateCode - refactored repeated code for generating Achievement QR Code

  1. Did you do pair or mob programming?

No

@vladislav-kir vladislav-kir self-assigned this Feb 27, 2025
Copy link
Member

@jernejk jernejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an interesting bug that would have no impact on the application but was interesting for me to verify that I know the difference between ?? and ??= when it comes to the order of operation. :)

Other than the suggested change, LGTM.

Remove `=` in `??=` to avoid mutating `newUser.FullName` value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants