Skip to content

๐Ÿ› Fix: completedLessons๋ฅผ ์™„๋ฃŒ ๊ธฐ์ค€์œผ๋กœ ์ง‘๊ณ„ (์ง„ํ–‰๋ฅ ๊ณผ ์ผ๊ด€) - #119

Merged
naooung merged 1 commit into
developfrom
fix/course-completed-lessons-count
Jun 16, 2026
Merged

๐Ÿ› Fix: completedLessons๋ฅผ ์™„๋ฃŒ ๊ธฐ์ค€์œผ๋กœ ์ง‘๊ณ„ (์ง„ํ–‰๋ฅ ๊ณผ ์ผ๊ด€)#119
naooung merged 1 commit into
developfrom
fix/course-completed-lessons-count

Conversation

@naooung

@naooung naooung commented Jun 16, 2026

Copy link
Copy Markdown
Member

์—ฐ๊ฒฐ Issue

closes #

์ž‘์—… ์œ ํ˜•

  • ๐Ÿ› Fix โ€” ๋ฒ„๊ทธ ์ˆ˜์ •

๋ณ€๊ฒฝ ๋‚ด์šฉ

๊ณผ์™ธ ์นด๋“œ์— "๊ฐ•์˜ 1/5" + "0%" ์ฒ˜๋Ÿผ ์ง„ํ–‰๋ฅ ๊ณผ ์™„๋ฃŒ ๊ฐ•์˜ ์ˆ˜๊ฐ€ ๋ชจ์ˆœ๋˜๊ฒŒ ํ‘œ์‹œ๋˜๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•œ๋‹ค.

์›์ธ

GET /tutoring(๋ชฉ๋กยท๋‹จ๊ฑด)์˜ completedLessons ์ง‘๊ณ„๊ฐ€ (isCompleted = true OR currentSlideIdx > 0) ์ฆ‰ ์ง„ํ–‰์ค‘์ธ ๊ฐ•์˜๊นŒ์ง€ ์„ธ๊ณ  ์žˆ์—ˆ๋‹ค. ๊ฐ•์˜๋ฅผ ์—ด๊ธฐ๋งŒ ํ•˜๊ณ  ๋๋‚ด์ง€ ์•Š์œผ๋ฉด(currentSlideIdx>0, isCompleted=false) completedLessons=1๋กœ ์žกํžˆ๋Š”๋ฐ, progress(course.progressPercent)๋Š” ์™„๋ฃŒ ๊ธฐ์ค€์ด๋ผ 0% โ†’ ๋ชจ์ˆœ. (#118์—์„œ ์ง‘๊ณ„ ์˜๋„๋Š” "์™„๋ฃŒ ๊ฐ•์˜ ์ˆ˜"์˜€์œผ๋‚˜ ๊ตฌํ˜„์ด ์ง„ํ–‰ ํฌํ•จ์œผ๋กœ ๋“ค์–ด๊ฐ)

์ˆ˜์ • (์™„๋ฃŒ๋งŒ ์ง‘๊ณ„)

  • CourseService: countStudiedChapters(ByCourseIds) โ†’ countCompletedChapters(ByCourseIds) ๋กœ ํ˜ธ์ถœ ์ „ํ™˜.
    • ๋‹จ๊ฑด: ๊ธฐ์กด countCompletedByCourseIdAndUserId(isCompleted=true) ์žฌ์‚ฌ์šฉ.
    • ๋ชฉ๋ก: countCompletedByUserIdAndCourseIdIn(N+1 ๋ฐฉ์ง€ IN ์ฟผ๋ฆฌ) ์‹ ๊ทœ ์ถ”๊ฐ€.
  • studied ์ฟผ๋ฆฌ(์ง„ํ–‰ ํฌํ•จ)๋Š” ํ–ฅํ›„ "์ˆ˜๊ฐ•์ค‘" ํ‘œ์‹œ์šฉ์œผ๋กœ ๋ณด์กด(๋ฉ”์ธ ์ฝ”๋“œ ๋ฏธ์‚ฌ์šฉ, ์ฃฝ์€ ์ฝ”๋“œ ์•„๋‹˜).
  • progress์™€ completedLessons๊ฐ€ ๋‘˜ ๋‹ค ์™„๋ฃŒ ๊ธฐ์ค€์ด ๋ผ ์ผ๊ด€๋จ.

ํ…Œ์ŠคํŠธ ๋ฐฉ๋ฒ•

  • ./gradlew test --tests "com.swez.backend.domain.course.service.CourseServiceTest"
    • ๊ธฐ์กด completedLessons ๊ฒ€์ฆ์„ completed mock์œผ๋กœ ์ •์ •
    • ์‹ ๊ทœ ํšŒ๊ท€: ์ง„ํ–‰์ค‘๋งŒ ์žˆ๊ณ  ์™„๋ฃŒ 0์ด๋ฉด completedLessons == 0
  • ์ „์ฒด ./gradlew test BUILD SUCCESSFUL

์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • develop ๋ธŒ๋žœ์น˜์—์„œ ๋ถ„๊ธฐํ–ˆ๋‹ค
  • ๋ธŒ๋žœ์น˜ ๋„ค์ด๋ฐ ๊ทœ์น™(ํƒ€์ž…/์ž‘์—…๋‚ด์šฉ)์„ ๋”ฐ๋ž๋‹ค
  • ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๊ฐ€ {๊นƒ๋ชจ์ง€} {ํƒ€์ž…}: {๋‚ด์šฉ} ํ˜•์‹์„ ๋”ฐ๋ฅธ๋‹ค
  • ๊ด€๋ จ ๋ฌธ์„œ๋ฅผ ๋™์‹œ์— ์—…๋ฐ์ดํŠธํ–ˆ๋‹ค (ํ•„์š” ์‹œ)
  • Merge ํ›„ ๋ธŒ๋žœ์น˜ ์‚ญ์ œ ์˜ˆ์ •์ด๋‹ค

GET /tutoring ์˜ completedLessons๊ฐ€ (isCompleted OR currentSlideIdx>0) ์ฆ‰
์ง„ํ–‰์ค‘๊นŒ์ง€ ์„ธ๊ณ  ์žˆ์–ด, ๊ฐ•์˜๋ฅผ ์—ด๊ธฐ๋งŒ ํ•˜๊ณ  ๋๋‚ด์ง€ ์•Š์œผ๋ฉด progress=0%์ธ๋ฐ 1๊ฐ• ์™„๋ฃŒ๋กœ
ํ‘œ์‹œ๋˜๋Š” ๋ชจ์ˆœ์ด ์žˆ์—ˆ๋‹ค(#118์—์„œ ์ง‘๊ณ„ ์˜๋„๋Š” ์™„๋ฃŒ์˜€์œผ๋‚˜ ๊ตฌํ˜„์ด ์ง„ํ–‰ ํฌํ•จ).

- CourseService: countStudiedChapters(ByCourseIds) โ†’ countCompletedChapters(ByCourseIds)
  ๋กœ ์ „ํ™˜. ๋‹จ๊ฑด์€ ๊ธฐ์กด countCompletedByCourseIdAndUserId ์žฌ์‚ฌ์šฉ, ๋ชฉ๋ก์€
  countCompletedByUserIdAndCourseIdIn(isCompleted=true) ์‹ ๊ทœ ์ถ”๊ฐ€.
- studied ์ฟผ๋ฆฌ๋Š” ํ–ฅํ›„ "์ˆ˜๊ฐ•์ค‘" ํ‘œ์‹œ์šฉ์œผ๋กœ ๋ณด์กด(๋ฉ”์ธ ์ฝ”๋“œ ๋ฏธ์‚ฌ์šฉ).
- CourseServiceTest: completed mock์œผ๋กœ ์ •์ • + ์ง„ํ–‰์ค‘๋งŒ ์žˆ์„ ๋•Œ completedLessons=0 ํšŒ๊ท€ ์ถ”๊ฐ€
@naooung
naooung merged commit 5132680 into develop Jun 16, 2026
1 check passed
@naooung
naooung deleted the fix/course-completed-lessons-count branch June 16, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant