Repository navigation
Inspect: support maintenance bookings and recurring schedules - #133
Open
JonasScholl wants to merge 1 commit into
Open
JonasScholl wants to merge 1 commit into
JonasScholl wants to merge 1 commit into
Conversation
JonasScholl
force-pushed
the
feature/maintenance
branch
from
October 8, 2026 17:43
36d92fc to
4cafb7c
Compare
JonasScholl
added this pull request to stack #134
October 8, 2026 20:20
JonasScholl
force-pushed
the
feature/maintenance
branch
from
October 8, 2026 20:21
4cafb7c to
326c0ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
app.inspectnow supports the full maintenance booking lifecycle: reading and filtering, impact previews, creation, complete updates, locking/unlocking, starting immediately, and deletion. Write operations run through explicit methods, independently of topology transactions.expected_rev. Errors include operation and server details; writes are not automatically retried after uncertain transport failures.Recurring schedules
Daily, weekly, and monthly rules expand into dated one-time bookings created in a single request. Each booking has its own server-returned ID and is managed independently. Impact previews evaluate each window separately.
This implementation accounts for behavior observed on VideoIPath 2026.2.0: native recurrence requests produced a broad booking window that could not subsequently be updated. SDK expansion handles IANA timezones and daylight saving time rules, with a limit of 1,000 complete windows per request. Nonempty server-specific iteration filters are explicitly rejected during expansion; transport models preserve these fields. Older server versions have not been verified.
Validation
poetry run test-unit: 628 tests passed.poetry run test-e2e tests/e2e/apps/test_inspect_maintenance.py: 8 live cases passed on 2026.2.0. Coverage includes exact windows, persisted metadata, revision conflicts, lock preservation, start-now, searching and filtering, independent recurring occurrences, module/port/edge targets, open-ended windows, and staged topology edits.E2E-labels and thevipat-e2etag. Cleanup verifies booking removal first, then device removal from Inspect and Inventory; no global sweep is performed.Live impact checks use isolated mock resources without services. Populated impact responses are also tested offline.