fix(proxy): handle Read argument snapshot deltas#217
Merged
Conversation
975a5fc to
be456ad
Compare
Buffer Read tool argument chunks as discrete deltas so normal split JSON still joins correctly, while non-standard providers that resend complete JSON snapshots fall back to the latest complete object when done.arguments is missing.\n\nRefs #197
be456ad to
baad825
Compare
Owner
Author
|
cc @unive3sal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readtool arguments whenresponse.function_call_arguments.doneomitsarguments.Read.pages == ""sanitizer and avoid rewriting/clampingoffsetbecause the proxy does not have file context.Refs #197
Verification
cargo fmt --manifest-path src-tauri/Cargo.toml -- --checkcargo test --manifest-path src-tauri/Cargo.toml read_tool_snapshot_argument_deltas_use_latest_complete_jsoncargo test --manifest-path src-tauri/Cargo.toml read_tool_split_argument_deltas_are_still_joinedcargo test --manifest-path src-tauri/Cargo.toml read_tool_incomplete_argument_deltas_are_not_treated_as_snapshotscargo test --manifest-path src-tauri/Cargo.toml read_tool_duplicate_start_preserves_buffered_argumentscargo test --manifest-path src-tauri/Cargo.toml non_read_tool_empty_delta_still_uses_done_argumentscargo test --manifest-path src-tauri/Cargo.toml read_tool_arguments_are_buffered_and_sanitizedgit diff --check