fix: resolve feedbackUtils test relative import and mock localStorage globally#5316
Open
DebasmitaBose0 wants to merge 1 commit into
Open
Conversation
|
@DebasmitaBose0 is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5315
Summary
Fixes import resolution crashes and ReferenceError bugs in
tests/feedbackUtils.test.mjsby correcting relative target directories and providing a fully functionallocalStoragesimulation.Changes Made
../src/utils/feedbackUtils.js.globalThis.localStoragemock to safely trap state transactions during testing.expectwrapper mapping to nativenode:assert.Testing
node --test --import "data:text/javascript,import { register } from 'node:module'; import { pathToFileURL } from 'node:url'; register('./tests/loaders/jsExtension.mjs', pathToFileURL('./'));" tests/feedbackUtils.test.mjsImpact
Enables automated verification of feedback calculations and export routines, enhancing code coverage metrics.
Checklist