Add descriptive labels to hackathon icon buttons#5382
Open
Akshith-cdr wants to merge 2 commits into
Open
Conversation
|
@Akshith-cdr is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3442
Added descriptive accessible labels to Hackathon page icon buttons and controls, including whiteboard tools, color and brush selectors, undo/clear actions, sticky note deletion, team workspace delete/unpin/close actions, and lifecycle action buttons.
Also added a regression test to prevent generic
aria-label="button"values and title-only Hackathon buttons from returning.Type of change
Screenshots / Video (if applicable)
N/A
Checklist
npm testand verified they passnpm run lintand resolved any new errors or warningsTest run:
node tests\hackathonIconButtonLabels.test.mjs