Skip to content

🎉 Advance DrHeader to evalute HSTS max-age #250:bug #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuel-sommer wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

🎉 Advance DrHeader to evalute HSTS max-age #250:bug #251

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f0e182
:tada: Advance DrHeader to evalute HSTS max-age #250:bug
manuel-sommer Jun 24, 2022
49d831f
evaluate hsts with greaterequal-age
manuel-sommer Nov 14, 2023
29085aa
Merge branch 'develop' into add_HSTSmax-age_evaluation
danielcuthbert Jul 23, 2024
d944e52
Merge branch 'develop' into add_HSTSmax-age_evaluation
manuel-sommer Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions drheader/validators/header_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,31 @@ def value(self, config, header, **kwargs):
header_value = self.headers[header]
strip_chars = base.get_delimiter(config, 'strip') if header.lower() in _STRIP_HEADERS else None
header_items = utils.parse_policy(header_value, item_delimiter=delimiter, strip_chars=strip_chars)

if config.get('preserve-order'):
header_items = [item.lower() for item in header_items]
expected_lower = [item.lower() for item in expected]
else:
header_items = {item.lower() for item in header_items}
expected_lower = {item.lower() for item in expected}

if header_items != expected_lower:
if header == "Strict-Transport-Security" and any("greaterequal-age" in item for item in expected_lower):
severity = config.get('severity', 'high')
error_type = ErrorType.VALUE
expected_header_items_without_gea = []
for item in expected_lower:
if "greaterequal-age" in item:
greaterequalage = item.strip("greaterequal-age=")
else:
expected_header_items_without_gea.append(item.lower())
maxage=0
header_items_without_gea = []
for item in header_items:
if "max-age" in item:
maxage = item.strip("max-age=")
else:
header_items_without_gea.append(item.lower())
if int(greaterequalage) > int(maxage) or header_items_without_gea != expected_header_items_without_gea:
return ReportItem(severity, error_type, header, value=header_value, expected=expected, delimiter=delimiter)
elif header_items != expected_lower:
severity = config.get('severity', 'high')
error_type = ErrorType.VALUE
return ReportItem(severity, error_type, header, value=header_value, expected=expected, delimiter=delimiter)
Expand Down