Fix: Clone dependencies via HTTPS instead of SSH#18
Draft
K1li4nL wants to merge 1 commit intoSantandersecurityresearch:devfrom
Draft
Fix: Clone dependencies via HTTPS instead of SSH#18K1li4nL wants to merge 1 commit intoSantandersecurityresearch:devfrom
K1li4nL wants to merge 1 commit intoSantandersecurityresearch:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Santander team,
First, thank you very much for this tool. As I played with it I noticed that the installation of dependencies requires git clone via SSH, which for GitHub repos require an SSH key associated to an account.
This PR aims to fix that by simply using HTTPS.
Best,
Kilian