Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Discovery upgrade scenario to new format #16898

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Convert Discovery upgrade scenario to new format #16898

wants to merge 2 commits into from

Conversation

synkd
Copy link
Contributor

@synkd synkd commented Nov 12, 2024

As part of the current upgrade scenarios refactor, this PR converts the Discovery pre-upgrade scenario to a Pytest fixture and modifies the pre- and post-upgrade scenarios to use the SharedResource framework.

@synkd synkd added Upgrades Issues and PRs related to upgrades CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 12, 2024
@synkd
Copy link
Contributor Author

synkd commented Nov 12, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_discovery.py
env:
BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9343
Build Status: SUCCESS
PRT Comment: pytest tests/new_upgrades/test_discovery.py --external-logging
Test Result : ================= 1 passed, 19 warnings in 2645.89s (0:44:05) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 12, 2024
vsedmik
vsedmik approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@synkd Would you mind to update the CODEOWNERS file with the new addition? We use it for the team-based review requests / heads up. Thank you!

@synkd synkd force-pushed the convert_discovery_scenario_to_new_format branch from c202abc to 385284d Compare November 13, 2024 14:58
@synkd synkd requested a review from a team as a code owner November 13, 2024 14:58
@synkd
Copy link
Contributor Author

synkd commented Nov 13, 2024 •
edited
Loading

@synkd Would you mind to update the CODEOWNERS file with the new addition? We use it for the team-based review requests / heads up. Thank you!

@vsedmik Added, thanks for pointing that out.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@synkd synkd

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches Upgrades Issues and PRs related to upgrades
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@synkd @Satellite-QE @vsedmik