Fix db connection pool exhausting issue

SavinduDimal · Sep 23, 2024 · 8f7a8c4 · 8f7a8c4
1 parent cebaf7a
commit 8f7a8c4
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java b/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java
@@ -14720,13 +14720,12 @@ private List<Object> buildUpdateParams(LLMProvider provider) {
     public LLMProvider getLLMProvider(String organization, String llmProviderId) throws APIManagementException {
 
         String errorMessage = "Failed to get LLM Provider in tenant domain: " + organization;
-        try {
-            Connection connection = APIMgtDBUtil.getConnection();
-            String getLlmProviderSql = SQLConstants.GET_LLM_PROVIDER_SQL;
-            if (organization != null) {
-                getLlmProviderSql += " AND ORGANIZATION = ?";
-            }
-            PreparedStatement preparedStatement = connection.prepareStatement(getLlmProviderSql);
+        String getLlmProviderSql = SQLConstants.GET_LLM_PROVIDER_SQL;
+        if (organization != null) {
+            getLlmProviderSql += " AND ORGANIZATION = ?";
+        }
+        try (Connection connection = APIMgtDBUtil.getConnection();
+                PreparedStatement preparedStatement = connection.prepareStatement(getLlmProviderSql)) {
             preparedStatement.setString(1, llmProviderId);
             if (organization != null) {
                 preparedStatement.setString(2, organization);